Add test validating cluster name generation is unique in HTTPRoute with BackendTLSPolicy vs HTTPProxy #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianang
force-pushed
the
test-cluster-name-btp
branch
2 times, most recently
from
ebf88aa
to
28ca751
Compare
christianang
changed the title
christianang
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
izturn and
clayton-gonsalves
and removed request for
a team
christianang
changed the title
christianang
force-pushed
the
test-cluster-name-btp
branch
from
28ca751
to
4bacca8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6195 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 133 133
Lines 15772 15772
=======================================
Hits 12828 12828
Misses 2650 2650
Partials 294 294
|
christianang
changed the title
sunjayBhatia
added
the
release-note/none-required
- add a test to ensure that two clusters with different tls settings due to one being created with HTTPRoute and BackendTLSPolicy vs HTTPProxy have different cluster names Signed-off-by: Christian Ang <christian.ang@broadcom.com>
- to differentiate resources with the same name Signed-off-by: Christian Ang <christian.ang@broadcom.com>
christianang
force-pushed
the
test-cluster-name-btp
branch
from
4bacca8
to
e506bcb
Compare
sunjayBhatia
approved these changes
Feb 23, 2024
lubronzhan
pushed a commit
to lubronzhan/contour
that referenced
this pull request
Mar 13, 2024
…th BackendTLSPolicy vs HTTPProxy (projectcontour#6195) add a test to ensure that two clusters with different tls settings due to one being created with HTTPRoute and BackendTLSPolicy vs HTTPProxy have different cluster names Also adds type to statusupdatercache - to differentiate resources with the same name Signed-off-by: Christian Ang <christian.ang@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR validates that the cluster name generation creates unique names when the tls settings are different due to creating one cluster using HTTPRoute with BackendTLSPolicy and another with HTTPProxy.
This PR also makes a small refactor of adding the type to the
StatusUpdateCacherto differentiate resources with the same name but different types.Fixes #6141